Repository navigation
fix(hosting): skip Accept-Language candidates with q<=0 or non-finite q - #795
Closed
ShahadatTest wants to merge 1 commit into
Closed
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
LocaleMiddleware._negotiate treated q=0 like any other weight, so Accept-Language: es;q=0 selected es. Skip not-acceptable and nan/inf weights so negotiation falls through to a real preference or default. Fixes antosubash#792
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocaleMiddleware._negotiateskips Accept-Language entries withq<=0(RFC 9110 §12.4.2 “not acceptable”) and non-finite q values (nan/inf).es;q=0falling through to the default, and for non-finite weights not winning the sort.Fixes #792
Test plan
uv run --package simple_module_hosting --with pytest --with python-multipart --with pytest-benchmark pytest framework/hosting/tests/test_locale_middleware.py -q -o addopts=(11 passed)AI disclosure: This contribution was prepared with assistance from Cursor (AI). I reviewed and verified the change and tests before opening this PR.